-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: add ignore missing to text chunking processor #8266
[Feature]: add ignore missing to text chunking processor #8266
Conversation
Signed-off-by: Ian Menendez <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
@kolchfa-aws This PR is for since 2.18. |
Signed-off-by: kolchfa-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IanMenendez @kolchfa-aws LGTM 😄
The PR: opensearch-project/neural-search#907 is still under review. Please merge this PR after the PR gets merged. |
We can merge this. opensearch-project/neural-search/pull/907 is now merged |
Pinging @kolchfa-aws and @natebower for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuye-aws LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ready to merge.
Description
Adds ignore missing field to text chunking processor
Issues Resolved
Closes:
opensearch-project/neural-search#906
opensearch-project/neural-search#907
Version
2.18.0
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.