Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add ignore missing to text chunking processor #8266

Conversation

IanMenendez
Copy link
Contributor

@IanMenendez IanMenendez commented Sep 13, 2024

Description

Adds ignore missing field to text chunking processor

Issues Resolved

Closes:
opensearch-project/neural-search#906
opensearch-project/neural-search#907

Version

2.18.0

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@yuye-aws
Copy link
Member

@kolchfa-aws This PR is for since 2.18.

@kolchfa-aws kolchfa-aws added the release-notes PR: Include this PR in the automated release notes label Sep 26, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuye-aws
Copy link
Member

The PR: opensearch-project/neural-search#907 is still under review. Please merge this PR after the PR gets merged.

@IanMenendez
Copy link
Contributor Author

IanMenendez commented Oct 3, 2024

We can merge this. opensearch-project/neural-search/pull/907 is now merged

@kolchfa-aws

@yuye-aws
Copy link
Member

yuye-aws commented Oct 8, 2024

Pinging @kolchfa-aws and @natebower for review.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuye-aws LGTM

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge.

@kolchfa-aws kolchfa-aws merged commit 8feea9e into opensearch-project:main Oct 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants