Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP Host step #562

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

dbwiddis
Copy link
Member

Description

Removes the HttpHost step, essentially reverting #530. That PR was meant as incremental progress towards a full feature that was later pushed to 2.14. It needs to be revised/changed (such as allowlist validation) so I'd prefer it not be a part of the 2.13 release as it adds no value and would only cause confusion.

The process of reviewing #530 was educational in identifying future requirements for that step.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <[email protected]>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (4bf6e32) to head (b9f6570).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #562      +/-   ##
============================================
- Coverage     72.91%   72.62%   -0.29%     
+ Complexity      675      665      -10     
============================================
  Files            79       78       -1     
  Lines          3452     3416      -36     
  Branches        273      271       -2     
============================================
- Hits           2517     2481      -36     
  Misses          818      818              
  Partials        117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 1ff9649 into opensearch-project:main Mar 12, 2024
32 checks passed
@dbwiddis dbwiddis deleted the remove-httphost branch March 12, 2024 18:12
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-562-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ff9649b141e80d3215715bf99cd8cc521c4f226
# Push it to GitHub
git push --set-upstream origin backport/backport-562-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-562-to-2.x.

dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Mar 12, 2024
dbwiddis added a commit that referenced this pull request Mar 12, 2024
Remove HTTP Host step (#562)

Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants