Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky testGeoHexGridBucket #632

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ryanbogan
Copy link
Member

Description

Temporarily changes the max precision to 14 instead of 15, since there is a bug that fails on 15

Issue created for bug: #629

Note: this change is already on branch 2.12, as it was merged before release of 2.12.0

Issues Resolved

#619

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan ryanbogan added backport 2.x Backport PR to 2.x branch skip-changelog labels Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (a7ed59a) to head (12eb7ab).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #632      +/-   ##
============================================
+ Coverage     88.96%   89.00%   +0.03%     
- Complexity      765      766       +1     
============================================
  Files            93       93              
  Lines          2746     2746              
  Branches        223      223              
============================================
+ Hits           2443     2444       +1     
  Misses          221      221              
+ Partials         82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@VijayanB
Copy link
Member

The test failure is not related.

@VijayanB VijayanB merged commit ab578ae into opensearch-project:main Mar 28, 2024
36 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit ab578ae)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit ab578ae)
navneet1v pushed a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit ab578ae)

Co-authored-by: Ryan Bogan <[email protected]>
navneet1v pushed a commit that referenced this pull request Mar 28, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit ab578ae)

Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants