Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial version of data-prepper helm chart #547

Merged

Conversation

SergK
Copy link
Contributor

@SergK SergK commented Jun 2, 2024

Description

Let's start with the initial version of the data-prepper.
We can extend it later with more examples of configuration

Issues Resolved

Related issue: #45

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SergK
Copy link
Contributor Author

SergK commented Jun 7, 2024

Hello @TheAlgo, any chance to push this forward?

@ruanyl
Copy link
Member

ruanyl commented Jun 12, 2024

@SergK I'm getting error log No configuration found for '2cdf8d8a' at 'null' in 'null', this seems relate to log4j configuration, have you seen the error?

Full log outputs

Reading pipelines and data-prepper configuration files from Data Prepper home directory.
/usr/bin/java
Found openjdk version  of 17.0
2024-06-12T07:48:36.473380208Z main ERROR Reconfiguration failed: No configuration found for '2cdf8d8a' at 'null' in 'null'

@SergK
Copy link
Contributor Author

SergK commented Jun 12, 2024

@ruanyl yep, fix is on the way in a 20 minutes

@SergK SergK force-pushed the initial-data-prepper-charts branch from be4dd64 to 52acabe Compare June 12, 2024 08:20
@SergK
Copy link
Contributor Author

SergK commented Jun 12, 2024

@ruanyl I've fixed the issue

@SergK SergK force-pushed the initial-data-prepper-charts branch from 52acabe to bfdde9c Compare June 12, 2024 16:49
@SergK
Copy link
Contributor Author

SergK commented Jun 12, 2024

fixed ci issue

@ruanyl
Copy link
Member

ruanyl commented Jun 18, 2024

@ruanyl I've fixed the issue

Tried another time and it works fine for me 👍

@TheAlgo Could we get more reviewers on this PR?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jun 18, 2024

Thanks @SergK for contribution.
Adding @TheAlgo @DandyDeveloper @smlx @prudhvigodithi to take a look.

Thanks.

@prudhvigodithi
Copy link
Collaborator

Thanks @SergK I will take the opportunity to review this and we can ship this chart.
Thank you

@prudhvigodithi
Copy link
Collaborator

Thanks for your contribution @SergK the initial version of the chart LGTM, please add the CHANGELOG.md and README.md files similar to what we have for other charts in this repo.
Thanks
@getsaurabh02

@prudhvigodithi
Copy link
Collaborator

We can move forward with this PR once we have the CHANGELOG.md and README.md files added and also I see no blocker for releasing this helm chart (using https://github.com/opensearch-project/helm-charts/blob/main/.github/workflows/release.yaml) and publishing to https://artifacthub.io/packages/search?org=opensearch-project&sort=relevance&page=1.

@SergK SergK force-pushed the initial-data-prepper-charts branch from bfdde9c to 435546f Compare June 24, 2024 07:15
@SergK
Copy link
Contributor Author

SergK commented Jun 24, 2024

@prudhvigodithi done

@TheAlgo
Copy link
Member

TheAlgo commented Jun 24, 2024

Thanks @SergK for the contribution and apologies for late review. I will review it sometime today.

Let's start with initial version of data-prepper.
We can extend it later with more examples of configuration

Related issue: opensearch-project#45

Signed-off-by: Sergiy Kulanov <[email protected]>
@SergK SergK force-pushed the initial-data-prepper-charts branch from 435546f to 013b3a4 Compare June 24, 2024 15:41
@prudhvigodithi
Copy link
Collaborator

Hey @TheAlgo following up on this PR, can you please take a look and add your thoughts on the PR?
Thank you
@getsaurabh02

Copy link
Member

@TheAlgo TheAlgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a CI similar to opensearch and opensearch-dashboards here?

@prudhvigodithi
Copy link
Collaborator

Should we add a CI similar to opensearch and opensearch-dashboards here?

Thanks @TheAlgo yes eventually we need them @SergK.

@prudhvigodithi prudhvigodithi merged commit a018f83 into opensearch-project:main Jul 3, 2024
8 checks passed
@prudhvigodithi
Copy link
Collaborator

The release is successful https://github.com/opensearch-project/helm-charts/releases/tag/data-prepper-0.1.0

helm search repo opensearch/data-prepper
NAME                   	CHART VERSION	APP VERSION	DESCRIPTION                  
opensearch/data-prepper	0.1.0        	2.8.0      	A Helm chart for Data Prepper

Will wait to get the artifacthub updated https://artifacthub.io/packages/search?repo=opensearch-project-helm-charts&sort=relevance&page=1
Thanks @SergK

VILJkid pushed a commit to Obmondo/helm-charts-1 that referenced this pull request Aug 21, 2024
…ect#547)

Let's start with initial version of data-prepper.
We can extend it later with more examples of configuration

Related issue: opensearch-project#45

Signed-off-by: Sergiy Kulanov <[email protected]>
Signed-off-by: VILJkid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants