Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 1.x] fix: resolve helm lint errors with extraObjects #608

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[backport 1.x] fix: resolve helm lint errors with extraObjects #608

merged 2 commits into from
Oct 24, 2024

Commits on Oct 20, 2024

  1. Resolve helm lint invalid Yaml error 

    If using `extraObjects`, the generated manifest fails `helm lint` with:

```shell
[ERROR] templates/extraManifests.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: apps/v1
```

This is a known issue [1] just with the go templates used for helm lint
and doesn't apply to the actual template that is applied. The fix [2]
is to make the whitespace work for both commands.

[1] helm/helm#10149
[2] helm/helm#10149 (comment)

Signed-off-by: Martin Rowe <[email protected]>
    @cyanidium
    cyanidium committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d00104b View commit details
    Browse the repository at this point in the history

  2. Bump version to 1.31.1 and 1.24.1 

    Signed-off-by: Martin Rowe <[email protected]>
    @cyanidium
    cyanidium committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    049b19e View commit details
    Browse the repository at this point in the history