Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action #1208

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jul 17, 2024

Description

Fix github actions
Reference
opensearch-project/k-NN#1795

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn
Copy link
Member Author

bwc test not able to have a healthy cluster
docker security and security tests have failures
these are not the goal of this PR

Signed-off-by: bowenlan-amzn <[email protected]>
@Hailong-am
Copy link
Collaborator

should we remove java 11 and 17 for test and build workflow?

@bowenlan-amzn
Copy link
Member Author

@Hailong-am commented on Jul 18, 2024, 3:16 AM PDT:

should we remove java 11 and 17 for test and build workflow?

Can still keep it for now, following the github action on the core side https://github.com/opensearch-project/OpenSearch/blob/1299919a8b66916bb942cf91012dc3754438b1a1/.github/workflows/assemble.yml#L10

@bowenlan-amzn bowenlan-amzn merged commit 27bc664 into opensearch-project:main Jul 18, 2024
26 of 29 checks passed
@bowenlan-amzn bowenlan-amzn deleted the fix-gha branch July 18, 2024 15:54
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1208-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 27bc6649c8d3ecdeaf1814c7439adfb33269eaa2
# Push it to GitHub
git push --set-upstream origin backport/backport-1208-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1208-to-2.x.

bowenlan-amzn added a commit to bowenlan-amzn/index-management that referenced this pull request Jul 18, 2024
(cherry picked from commit 27bc664)
Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants