Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing snapshot bug #1257

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Fixing snapshot bug #1257

merged 3 commits into from
Sep 17, 2024

Conversation

tandonks
Copy link
Contributor

Description

Fixed a snapshot bug where partial snapshot was taken as success by replacing GetSnapshotStatus API with GetSnapshotAPI

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kshitij Tandon <[email protected]>
@vikasvb90
Copy link
Collaborator

LGTM 👍

@vikasvb90 vikasvb90 merged commit 809f85c into opensearch-project:main Sep 17, 2024
27 of 29 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1257-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 809f85ca2fc26c7b1ee1fd3060bd35bf56b46520
# Push it to GitHub
git push --set-upstream origin backport/backport-1257-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1257-to-2.x.

tandonks added a commit to tandonks/index-management that referenced this pull request Sep 18, 2024
Signed-off-by: Kshitij Tandon <[email protected]>
Co-authored-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 809f85c)
Hailong-am pushed a commit that referenced this pull request Sep 24, 2024
Signed-off-by: Kshitij Tandon <[email protected]>
Co-authored-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 809f85c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants