Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending notification when failing to acquire lock #668

Closed

Conversation

Angie-Zhang
Copy link
Contributor

@Angie-Zhang Angie-Zhang commented Jan 18, 2023

Issue #, if available:
#666

This PR will be reviewed and merged after #667 merged.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Angie Zhang added 2 commits January 18, 2023 07:49
Signed-off-by: Angie Zhang <[email protected]>
@Angie-Zhang Angie-Zhang requested a review from a team January 18, 2023 16:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #668 (3373c57) into main (2241a29) will decrease coverage by 0.08%.
The diff coverage is 41.86%.

@@             Coverage Diff              @@
##               main     #668      +/-   ##
============================================
- Coverage     74.71%   74.63%   -0.08%     
- Complexity     2790     2795       +5     
============================================
  Files           366      366              
  Lines         16365    16425      +60     
  Branches       2346     2358      +12     
============================================
+ Hits          12227    12259      +32     
- Misses         2844     2864      +20     
- Partials       1294     1302       +8     
Files Coverage Δ
...ent/indexstatemanagement/util/NotificationUtils.kt 0.00% <0.00%> (ø)
...agement/indexstatemanagement/ManagedIndexRunner.kt 46.04% <43.37%> (-0.73%) ⬇️

... and 7 files with indirect coverage changes

@Angie-Zhang Angie-Zhang changed the title Notif lock fail Send notification when failing to acquire lock Jan 18, 2023
@Angie-Zhang Angie-Zhang changed the title Send notification when failing to acquire lock Sending notification when failing to acquire lock Jan 18, 2023
@dblock
Copy link
Member

dblock commented Jul 15, 2024

@Angie-Zhang @bowenlan-amzn Want to rebase and finish this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants