Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onetime notification settings when index operation finish #839

Conversation

Hailong-am
Copy link
Collaborator

Issue #, if available:
#835

Description of changes:
Remove onetime notification setting when index operation complete

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am Hailong-am force-pushed the bug/remove_onetime_notificaiton_setting branch from a282704 to eb7fb29 Compare July 3, 2023 02:37
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #839 (6cbb776) into main (bdc9dad) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #839      +/-   ##
============================================
+ Coverage     75.85%   75.87%   +0.02%     
- Complexity     2850     2854       +4     
============================================
  Files           364      364              
  Lines         16176    16178       +2     
  Branches       2325     2327       +2     
============================================
+ Hits          12270    12275       +5     
+ Misses         2567     2563       -4     
- Partials       1339     1340       +1     
Impacted Files Coverage Δ
...controlcenter/notification/ControlCenterIndices.kt 92.85% <0.00%> (+17.85%) ⬆️
.../notification/filter/NotificationActionListener.kt 80.00% <100.00%> (+1.13%) ⬆️

... and 13 files with indirect coverage changes

@Hailong-am Hailong-am changed the title remove onetime notification settings Remove onetime notification settings when index operation finish Jul 3, 2023
@Hailong-am Hailong-am merged commit 2a9bcd6 into opensearch-project:main Jul 3, 2023
13 of 15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 3, 2023
Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 2a9bcd6)
@Hailong-am Hailong-am deleted the bug/remove_onetime_notificaiton_setting branch July 3, 2023 08:51
Hailong-am added a commit that referenced this pull request Jul 3, 2023
Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 2a9bcd6)

Co-authored-by: Hailong Cui <[email protected]>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…arch-project#843)

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 2a9bcd6)

Co-authored-by: Hailong Cui <[email protected]>
Signed-off-by: Ronnak Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants