Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copy alias in rollover (2.x) #908

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Aug 26, 2023

Issue #, if available:

Description of changes:

Backport #892

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Support copy alias in rollover

Signed-off-by: bowenlan-amzn <[email protected]>

* Add more tests

Signed-off-by: bowenlan-amzn <[email protected]>

* Add bwc test

Signed-off-by: bowenlan-amzn <[email protected]>

* Enhance tests

Signed-off-by: bowenlan-amzn <[email protected]>

* Improve not acknowledge call scenario

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #908 (ed81612) into 2.x (344d63c) will decrease coverage by 0.28%.
The diff coverage is 90.27%.

@@             Coverage Diff              @@
##                2.x     #908      +/-   ##
============================================
- Coverage     76.08%   75.81%   -0.28%     
+ Complexity     2910     2894      -16     
============================================
  Files           366      366              
  Lines         16565    16631      +66     
  Branches       2399     2413      +14     
============================================
+ Hits          12604    12608       +4     
- Misses         2579     2635      +56     
- Partials       1382     1388       +6     
Files Changed Coverage Δ
...atemanagement/step/rollover/AttemptRolloverStep.kt 74.07% <88.88%> (+9.74%) ⬆️
...ment/indexstatemanagement/action/RolloverAction.kt 93.10% <100.00%> (+0.79%) ⬆️
...ndexstatemanagement/action/RolloverActionParser.kt 92.85% <100.00%> (+0.85%) ⬆️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 76.21% <100.00%> (-1.67%) ⬇️

... and 17 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review August 26, 2023 03:13
@bowenlan-amzn bowenlan-amzn changed the title Support copy alias in rollover (#892) Support copy alias in rollover (2.x) Aug 26, 2023
@bowenlan-amzn bowenlan-amzn merged commit 0690cdd into opensearch-project:2.x Sep 1, 2023
14 checks passed
@bowenlan-amzn bowenlan-amzn deleted the backport8922x branch September 1, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants