Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unique id for each rollup job and add debug logs #968

Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Oct 1, 2023

Issue #, if available:

Description of changes:

Prepare to resolve flaky test #90 (comment)

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <[email protected]>
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #968 (285a8eb) into main (a2dd769) will increase coverage by 0.13%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##               main     #968      +/-   ##
============================================
+ Coverage     75.55%   75.69%   +0.13%     
- Complexity     2842     2844       +2     
============================================
  Files           364      364              
  Lines         16263    16266       +3     
  Branches       2343     2343              
============================================
+ Hits          12288    12312      +24     
+ Misses         2626     2609      -17     
+ Partials       1349     1345       -4     
Files Coverage Δ
.../opensearch/indexmanagement/rollup/RollupRunner.kt 59.29% <ø> (ø)
...ch/indexmanagement/rollup/RollupMetadataService.kt 77.57% <37.50%> (-0.16%) ⬇️

... and 11 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn merged commit 9d9930c into opensearch-project:main Oct 2, 2023
14 of 15 checks passed
@bowenlan-amzn bowenlan-amzn deleted the rollup-flaky-test branch October 2, 2023 18:26
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2023
* Provide unique id for each rollup job and add debug logs

Signed-off-by: bowenlan-amzn <[email protected]>

* Remove conflict rollup ids

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 9d9930c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon pushed a commit that referenced this pull request Oct 2, 2023
* Provide unique id for each rollup job and add debug logs



* Remove conflict rollup ids



---------


(cherry picked from commit 9d9930c)

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Joshua152 pushed a commit to Joshua152/index-management that referenced this pull request Oct 10, 2023
…project#968)

* Provide unique id for each rollup job and add debug logs

Signed-off-by: bowenlan-amzn <[email protected]>

* Remove conflict rollup ids

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants