Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist model definition in model metadata #1527
Persist model definition in model metadata #1527
Changes from 7 commits
98ef3dd
0ba728e
d24baad
70a2f31
cf049ea
1bf49c2
a1f9e81
bd723e2
4dcdaee
f3a5521
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need { and } at beginning and end? can we not skip it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added those to help with the recursion if there is a nested MethodComponentContext object. Otherwise, there is no way to differentiate the object from a normal field.
Check warning on line 288 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L288
Check warning on line 342 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L342
Check warning on line 346 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L346
Check warning on line 368 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L368
Check warning on line 374 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L374
Check warning on line 381 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L381
Check warning on line 388 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L388
Check warning on line 393 in src/main/java/org/opensearch/knn/index/MethodComponentContext.java
Codecov / codecov/patch
src/main/java/org/opensearch/knn/index/MethodComponentContext.java#L393