Add patch to fix arm segfault in nmslib during ingestion #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
added
Bug Fixes
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Signed-off-by: John Mazanec <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
============================================
- Coverage 85.17% 85.13% -0.04%
Complexity 1299 1299
============================================
Files 171 171
Lines 5295 5295
Branches 506 506
============================================
- Hits 4510 4508 -2
- Misses 572 574 +2
Partials 213 213 ☔ View full report in Codecov by Sentry. |
|
Thanks Jack. Just Curious why is this race condition CPU architecture dependent? |
naveentatikonda
approved these changes
Mar 14, 2024
martin-gaievski
approved these changes
Mar 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 2b0f5a3)
all details related to this is added on the GH issue of nmslib. Its more around how different CPU architectures are creating the assembly code. |
|
Right, the issue doesnt happen on x86 (that weve seen) because gcc on x86 doesnt re-order the assignment operations. But gcc on arm does - probably as some kind of optimization |
navneet1v
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 2b0f5a3) Co-authored-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds patch to fix the segfault happening in nmslib. For more information on the patch, see nmslib/nmslib#544.
Existing tests will cover this change. The issue can only be reproduced at large scales. I can confirm the patch has remedied seeing this issue in large OpenSearch clusters.
Issues Resolved
#1406
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.