Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support score type threshold in radial search #1589

Merged
merged 3 commits into from
Apr 5, 2024

Resolve feedback

d4f70de
Select commit
Loading
Failed to load commit list.
Merged

Support score type threshold in radial search #1589

Resolve feedback
d4f70de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2024 in 0s

84.85% (target 70.00%)

View this Pull Request on Codecov

84.85% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.85%. Comparing base (3701835) to head (d4f70de).
Report is 6 commits behind head on feature/radius-search.

Files Patch % Lines
...rg/opensearch/knn/index/query/KNNQueryBuilder.java 79.06% 4 Missing and 5 partials ⚠️
.../main/java/org/opensearch/knn/index/SpaceType.java 25.00% 2 Missing and 1 partial ⚠️
...main/java/org/opensearch/knn/index/util/Faiss.java 83.33% 0 Missing and 1 partial ⚠️
...ain/java/org/opensearch/knn/index/util/Lucene.java 80.00% 1 Missing ⚠️
...ain/java/org/opensearch/knn/index/util/Nmslib.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                     @@
##             feature/radius-search    #1589      +/-   ##
===========================================================
+ Coverage                    84.82%   84.85%   +0.02%     
- Complexity                    1400     1429      +29     
===========================================================
  Files                          174      174              
  Lines                         5713     5802      +89     
  Branches                       569      588      +19     
===========================================================
+ Hits                          4846     4923      +77     
- Misses                         621      630       +9     
- Partials                       246      249       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov