Add radial search feature to main branch #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#1498) Signed-off-by: Junqiu Lei <[email protected]>
…ect#1546) * Support distance type radius search for Faiss engine Signed-off-by: Junqiu Lei <[email protected]>
* Support score type threshold in radial search Signed-off-by: Junqiu Lei <[email protected]>
…ax_distance (opensearch-project#1609) * Rename radial search parameters score and distance to min_score and max_distance Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
added
Features
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski and
ryanbogan
as code owners
jmazanec15
reviewed
Apr 17, 2024
Signed-off-by: Junqiu Lei <[email protected]>
| } | ||
| if (isClusterOnOrAfterMinRequiredVersion(KNNConstants.RADIAL_SEARCH_KEY)) { | ||
| min_score = in.readOptionalFloat(); | ||
| } |
There was a problem hiding this comment.
nit: we can have both reads under case if case. not a blocker, can be done in a refactoring PR in future
There was a problem hiding this comment.
Sure, we can do it in future PR
martin-gaievski
approved these changes
Apr 17, 2024
|
There are a few tests that are failing still, though |
The failing test isn’t related to the PR, I saw same failings in other recent PRs. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1617-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 307609bbbff4889ecdf76d615157e223023c6df7
# Push it to GitHub
git push --set-upstream origin backport/backport-1617-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
MINIMAL_SUPPORTED_VERSION_FOR_RADIAL_SEARCHto 2.14Benchmark
#814 (comment)
Issues Resolved
Part of #814
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.