Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for ef_search query parameter in FAISS engine #1707

Merged
merged 18 commits into from
Jun 6, 2024
Merged

Adds support for ef_search query parameter in FAISS engine #1707

merged 18 commits into from
Jun 6, 2024

Commits on May 16, 2024

  1. Adds support for ef_search as a query parameter in faiss engine 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9cc3437 View commit details
    Browse the repository at this point in the history

  2. Fixing checkstyle 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2bf0d9f View commit details
    Browse the repository at this point in the history

  3. Corrects imports 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 16, 2024
    Configuration menu
    Copy the full SHA
    49c88ba View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Adds unit test for faiss_wrapper for queryIndex and queryIndexWithFilter 

    methods

This unit test specifically focuses on the changes related to ef_search
Detailed assertions related to grouper and selector can be picked up
later.

Tests related to any other methods are not added

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5c82673 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Gates efSearch behind 2.15 version to make sure there is backward 

    compatibility during upgrades

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 20, 2024
    Configuration menu
    Copy the full SHA
    5065709 View commit details
    Browse the repository at this point in the history

  2. Adds faiss_wrapper_unit_test.cpp in CmakeList 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 20, 2024
    Configuration menu
    Copy the full SHA
    55c6870 View commit details
    Browse the repository at this point in the history

  3. Adds change log 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4423df4 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Adds BWC tests for efSearch 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e041a98 View commit details
    Browse the repository at this point in the history

  2. Removes EfSearch validation from rolling upgrade test for Mixed cluster 

    state

Customers are not expected use the query with new parameters unless its
fully upgraded.

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2a0af55 View commit details
    Browse the repository at this point in the history

  3. Changing minimum version required for efSearch to be 3.0.0 

    This makes sure that bwc passes in the PR. will be changed to 2.15 to
once this is merged to 2.x

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d7ce682 View commit details
    Browse the repository at this point in the history

  4. Fixes the checkstyle failure 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4e6f886 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Adds method_parameter in knn search request. 

    method_parameters will be used to hold shard level algorithm parameters

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 28, 2024
    Configuration menu
    Copy the full SHA
    39dbe9b View commit details
    Browse the repository at this point in the history

  2. Updates the documentation for faiss wrapper 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 28, 2024
    Configuration menu
    Copy the full SHA
    555d407 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Stubs out method parameter parsing logic into its own class 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d7bc3ad View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Adds method parameters and validates against engine specific parameters 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d663640 View commit details
    Browse the repository at this point in the history

  2. Removes engine and method functions from EngineSpecificMethodContext 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    b726f40 View commit details
    Browse the repository at this point in the history

  3. - Does not throw in case of illegal state exception if method is null 

    - Changes HnswContext to DefaultHnswContext
- corrects * imports

Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    48c9a6f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/ef-search' into main 

    Signed-off-by: Tejas Shah <[email protected]>
    @shatejas
    shatejas authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    986706b View commit details
    Browse the repository at this point in the history