Removes KNNXparser and uses map instead #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves files from engine.method to index.util package Signed-off-by: Tejas Shah <[email protected]>
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
shatejas
commented
Jun 7, 2024
| @@ -22,6 +22,8 @@ | |||
| import java.util.HashMap; | |||
| import java.util.Map; | |||
| import java.util.function.BiFunction; | |||
| import java.util.List; | |||
| import java.util.ArrayList; | |||
There was a problem hiding this comment.
These two were somehow removed during the merge so added it back
jmazanec15
approved these changes
Jun 7, 2024
jmazanec15
merged commit 3602ab1
into
opensearch-project:feature/ef-search
36 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves files from engine.method to index.util package
Description
Follow up on #1707
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.