Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build. #1018

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix build. #1018

merged 2 commits into from
Jun 29, 2023

Conversation

Yury-Fridlyand
Copy link
Contributor

Description

Fix build. This blocks SQL plugin.

Issues Resolved

Fix build.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <[email protected]>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1018 (d3b5438) into 2.x (43d1b1a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1018      +/-   ##
============================================
+ Coverage     82.29%   82.32%   +0.02%     
  Complexity     1918     1918              
============================================
  Files           149      149              
  Lines          7506     7506              
  Branches        750      750              
============================================
+ Hits           6177     6179       +2     
+ Misses          988      987       -1     
+ Partials        341      340       -1     
Flag Coverage Δ
ml-commons 82.32% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yury-Fridlyand.
I've similar changes on PR: #1016 trying to fix 2.x

Signed-off-by: Yury-Fridlyand <[email protected]>
@b4sjoo b4sjoo merged commit df314fc into opensearch-project:2.x Jun 29, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-build branch August 11, 2023 01:11
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Aug 29, 2023
* Fix build.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Remove unused import.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
zane-neo added a commit that referenced this pull request Aug 29, 2023
* Fix build. (#1018)

* Fix build.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Remove unused import.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>

* fix format issue

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants