Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PenTest fixes: error codes and update model group fix #1074

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jul 11, 2023

Description

PenTest fixes: error codes and update model group fix

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1074 (9089f31) into 2.x (abdccc0) will decrease coverage by 0.07%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##                2.x    #1074      +/-   ##
============================================
- Coverage     77.98%   77.91%   -0.07%     
+ Complexity     2064     2060       -4     
============================================
  Files           167      167              
  Lines          8534     8535       +1     
  Branches        848      848              
============================================
- Hits           6655     6650       -5     
- Misses         1502     1507       +5     
- Partials        377      378       +1     
Flag Coverage Δ
ml-commons 77.91% <81.81%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/opensearch/ml/rest/RestMLPredictionAction.java 48.71% <0.00%> (ø)
...n/model_group/TransportUpdateModelGroupAction.java 77.86% <80.00%> (ø)
...arch/ml/action/models/GetModelTransportAction.java 82.35% <100.00%> (+0.35%) ⬆️
...search/ml/action/tasks/GetTaskTransportAction.java 62.50% <100.00%> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 62.63% <100.00%> (ø)
...ensearch/ml/rest/RestMLUpdateModelGroupAction.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@rbhavna rbhavna merged commit 83bbdae into opensearch-project:2.x Jul 11, 2023
8 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
* PenTest fixes: error codes and update model group fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix get model assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit 83bbdae)
rbhavna added a commit that referenced this pull request Jul 12, 2023
* PenTest fixes: error codes and update model group fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix get model assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit 83bbdae)

Co-authored-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
…ject#1074)

* PenTest fixes: error codes and update model group fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix get model assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
* PenTest fixes: error codes and update model group fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix get model assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants