Add more UT for remote inference classes #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sicheng Song <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1077 +/- ##
============================================
+ Coverage 77.95% 78.80% +0.85%
- Complexity 2071 2102 +31
============================================
Files 167 167
Lines 8558 8567 +9
Branches 857 862 +5
============================================
+ Hits 6671 6751 +80
+ Misses 1503 1423 -80
- Partials 384 393 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
reviewed
Jul 12, 2023
| String postProcessFunction = MLPostProcessFunction.OPENAI_EMBEDDING; | ||
| ConnectorAction action = new ConnectorAction(actionType, method, url, headers, mlCreateConnectorRequestBody, preProcessFunction, postProcessFunction); | ||
|
|
||
| // java.lang.IllegalStateException: unexpected byte [0x6f] will be thrown if we specify backendRoles field. |
There was a problem hiding this comment.
Change line 230 of MLCreateConnectorInput
output.writeOptionalStringCollection(backendRoles);
to
output.writeStringCollection(backendRoles);
Tested with this, it can work, won't throw such error
MLCreateConnectorInput input = MLCreateConnectorInput.builder()
.name("test_connector_name")
.description("this is a test connector")
.version("1")
.protocol("http")
.parameters(Map.of("input", "test input value"))
.credential(Map.of("key", "test_key_value"))
.access(AccessMode.PUBLIC)
.addAllBackendRoles(true)
.backendRoles(Arrays.asList("r1"))
.build();
BytesStreamOutput output = new BytesStreamOutput();
input.writeTo(output);
MLCreateConnectorInput input2 = new MLCreateConnectorInput(output.bytes().streamInput());
Assert.assertNotNull(input2);
Zhangxunmt
reviewed
Jul 12, 2023
Signed-off-by: Sicheng Song <[email protected]>
rbhavna
previously approved these changes
Jul 12, 2023
Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
commented
Jul 12, 2023
| MLConnectorGetResponse parsedResponse = new MLConnectorGetResponse(bytesStreamOutput.bytes().streamInput()); | ||
| assertNotEquals(response, parsedResponse); | ||
| assertNotSame(response.mlConnector, parsedResponse.mlConnector); | ||
| assertEquals(response.mlConnector, parsedResponse.mlConnector); |
There was a problem hiding this comment.
This class behaves different from https://github.com/opensearch-project/ml-commons/blob/2.x/common/src/test/java/org/opensearch/ml/common/transport/model/MLModelGetResponseTest.java#L48, is this expected? @ylwu-amzn
rbhavna
approved these changes
Jul 12, 2023
Zhangxunmt
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
(cherry picked from commit daab3b7)
b4sjoo
added a commit
to b4sjoo/ml-commons
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Sicheng Song <[email protected]>
5 tasks
b4sjoo
added a commit
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Sicheng Song <[email protected]>
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add test coverage to remote inference classes and some of the other classes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.