Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify error message when model group not unique is provided #1078

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jul 12, 2023

Description

modify error message when model group not unique is provided

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1078 (f6c8ffd) into 2.x (e3cb2e3) will increase coverage by 0.80%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##                2.x    #1078      +/-   ##
============================================
+ Coverage     77.95%   78.75%   +0.80%     
- Complexity     2071     2100      +29     
============================================
  Files           167      167              
  Lines          8558     8568      +10     
  Branches        857      862       +5     
============================================
+ Hits           6671     6748      +77     
+ Misses         1503     1426      -77     
- Partials        384      394      +10     
Flag Coverage Δ
ml-commons 78.75% <76.92%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/model_group/TransportUpdateModelGroupAction.java 77.34% <64.28%> (-0.53%) ⬇️
...a/org/opensearch/ml/model/MLModelGroupManager.java 84.48% <91.66%> (+38.94%) ⬆️

... and 2 files with indirect coverage changes

@rbhavna rbhavna merged commit df2a0f5 into opensearch-project:2.x Jul 12, 2023
9 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
* modify error message when model group not unique is provided

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix unique model group name unit test

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit df2a0f5)
rbhavna added a commit that referenced this pull request Jul 12, 2023
…1088)

* modify error message when model group not unique is provided

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix unique model group name unit test

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit df2a0f5)

Co-authored-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
…rch-project#1078)

* modify error message when model group not unique is provided

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix unique model group name unit test

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
* modify error message when model group not unique is provided

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix unique model group name unit test

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants