Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT Security Tests for model access control #1095

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jul 12, 2023

Description

IT Security Tests for model access control

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo
zane-neo previously approved these changes Jul 12, 2023
ylwu-amzn
ylwu-amzn previously approved these changes Jul 12, 2023
Signed-off-by: Bhavana Ramaram <[email protected]>
@rbhavna rbhavna dismissed stale reviews from ylwu-amzn and zane-neo via 1e0d583 July 12, 2023 10:38
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1095 (1e0d583) into 2.x (d9d1190) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                2.x    #1095      +/-   ##
============================================
- Coverage     79.01%   78.93%   -0.09%     
+ Complexity     2120     2118       -2     
============================================
  Files           167      167              
  Lines          8621     8630       +9     
  Branches        866      869       +3     
============================================
  Hits           6812     6812              
- Misses         1416     1425       +9     
  Partials        393      393              
Flag Coverage Δ
ml-commons 78.93% <66.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/model_group/TransportUpdateModelGroupAction.java 77.69% <66.66%> (+0.34%) ⬆️

... and 3 files with indirect coverage changes

@rbhavna rbhavna merged commit e752968 into opensearch-project:2.x Jul 12, 2023
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
* IT Security Tests for model access control

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit e752968)
rbhavna added a commit that referenced this pull request Jul 12, 2023
* IT Security Tests for model access control

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
(cherry picked from commit e752968)

Co-authored-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
* IT Security Tests for model access control

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
* IT Security Tests for model access control

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants