Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main]Disable shadowjar publishing to remove race condition of normal jar p… #1259

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

zane-neo
Copy link
Collaborator

…ublishing (#957)

Description

Backport #957 to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1259 (0abb844) into main (aa85254) will decrease coverage by 0.02%.
Report is 6 commits behind head on main.
The diff coverage is 84.44%.

@@             Coverage Diff              @@
##               main    #1259      +/-   ##
============================================
- Coverage     82.29%   82.28%   -0.02%     
- Complexity     1915     1920       +5     
============================================
  Files           149      149              
  Lines          7502     7508       +6     
  Branches        746      750       +4     
============================================
+ Hits           6174     6178       +4     
- Misses          986      989       +3     
+ Partials        342      341       -1     
Flag Coverage Δ
ml-commons 82.28% <84.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...opensearch/ml/helper/ModelAccessControlHelper.java 81.30% <50.00%> (+0.17%) ⬆️
...ain/java/org/opensearch/ml/engine/ModelHelper.java 90.00% <75.00%> (+0.27%) ⬆️
...n/model_group/TransportUpdateModelGroupAction.java 84.46% <81.48%> (-2.35%) ⬇️
...model_group/TransportRegisterModelGroupAction.java 90.62% <100.00%> (+3.25%) ⬆️
.../action/register/TransportRegisterModelAction.java 98.80% <100.00%> (-0.02%) ⬇️
...h/ml/action/upload_chunk/MLModelChunkUploader.java 87.60% <100.00%> (ø)
...upload_chunk/TransportRegisterModelMetaAction.java 88.46% <100.00%> (-0.43%) ⬇️

... and 1 file with indirect coverage changes

@zane-neo zane-neo merged commit be8c839 into opensearch-project:main Aug 28, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants