Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main][2.x] Adding an integration test for redeploying a model (#1016) #1264

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

zane-neo
Copy link
Collaborator

  • Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

  • Adding model group ID changes for tests

  • Fixing tests for ImmutableMap copy

  • Commenting wait out task for model

  • Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

  • Rebasing with 2.x

  • Adding logs to debug the test in GHA

  • GHA tests

  • Still debugging

  • Removing comment

  • Removing unnecessary changes

  • Removing logs


Description

Backport #1016 to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#1016)

* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding model group ID changes for tests

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Fixing tests for ImmutableMap copy

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Commenting wait out task for model

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding a failing integ test for redeploy model and fix breaking changes from OpenSearch core

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Rebasing with 2.x

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding logs to debug the test in GHA

Signed-off-by: Sarat Vemulapalli <[email protected]>

* GHA tests

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Still debugging

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing comment

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing unnecessary changes

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Removing logs

Signed-off-by: Sarat Vemulapalli <[email protected]>

---------

Signed-off-by: Sarat Vemulapalli <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1264 (9dcb731) into main (3074058) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1264      +/-   ##
============================================
- Coverage     82.31%   82.28%   -0.03%     
  Complexity     1920     1920              
============================================
  Files           149      149              
  Lines          7508     7508              
  Branches        750      750              
============================================
- Hits           6180     6178       -2     
- Misses          988      989       +1     
- Partials        340      341       +1     
Flag Coverage Δ
ml-commons 82.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@zane-neo zane-neo merged commit de860dd into opensearch-project:main Aug 30, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants