fix ML task index mapping #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
reviewed
Sep 13, 2024
| + MLTask.REMOTE_JOB_FIELD | ||
| + "\" : {\"type\": \"flat_object\"}\n" | ||
| + "\" : {\"type\": \"flat_object\"}, \n" |
There was a problem hiding this comment.
if we want to keep the consistency with other fields may be we can add + " \"" after this?
There was a problem hiding this comment.
Not quite get you, that will bring extra \" which will be a wrong index mapping
There was a problem hiding this comment.
Sorry the confusion. Please ignore my comment.
dhrubo-os
approved these changes
Sep 13, 2024
Zhangxunmt
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 091f5df)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 091f5df)
Zhangxunmt
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 091f5df) Co-authored-by: Yaliang Wu <[email protected]>
Zhangxunmt
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 091f5df) Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ML task index mapping
Related Issues
Resolves #2948
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.