Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bedrock batch job post process function; enhance remote job status parsing #2955

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Sep 15, 2024

Description

Fix two issues (find more details on #2954):

  1. Hard coded job status parsing
  2. Bedrock jobArn escaping issue

Related Issues

Resolves #2954

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn merged commit 0d26931 into opensearch-project:main Sep 16, 2024
7 of 8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
…s parsing (#2955)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 0d26931)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
…s parsing (#2955)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 0d26931)
ylwu-amzn added a commit that referenced this pull request Sep 16, 2024
…s parsing (#2955) (#2957)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 0d26931)

Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn added a commit that referenced this pull request Sep 16, 2024
…s parsing (#2955) (#2956)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 0d26931)

Co-authored-by: Yaliang Wu <[email protected]>
@@ -8,7 +8,6 @@
public enum MLTaskType {
TRAINING,
PREDICTION,
BATCH_PREDICTION,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the enum order will introduce bwc issue. We should only add enum object to the very last one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw it from a previous wrong order. So this is actually a fix. Ignore previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Get task can't work for some batch job
4 participants