[Backport 2.17] Bug Fix: Fix for rag processor throwing NPE when optional parameters are not provided #3066
+161
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not provided (opensearch-project#3057) * fix (rag npe): optional and empty fields are handled appropriately Signed-off-by: Pavan Yekbote <[email protected]> * fix: test cases Signed-off-by: Pavan Yekbote <[email protected]> * fix: format violations Signed-off-by: Pavan Yekbote <[email protected]> * tests: adding empty params test case Signed-off-by: Pavan Yekbote <[email protected]> * fix: remove wildcard import Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
samuel-oci
as code owners
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
ylwu-amzn
previously approved these changes
Oct 7, 2024
|
apply spotless. |
Signed-off-by: Pavan Yekbote <[email protected]>
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
approved these changes
Oct 7, 2024
ylwu-amzn
approved these changes
Oct 7, 2024
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
pyek-bot
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge conflicts to merge into 2.17 for PR: #3066
Related Issues
Resolves #2983
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.