Allow llmQuestion to be optional when llmMessages is used. (Issue #3… #3072
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsearch-project#3067) Signed-off-by: Austin Lee <[email protected]>
austintlee
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
HenryL27,
samuel-oci and
xinyual
as code owners
austintlee
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
austintlee
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
reviewed
Oct 8, 2024
| @@ -185,7 +187,7 @@ public GenerativeQAParameters( | |||
| public GenerativeQAParameters(StreamInput input) throws IOException { | |||
| this.conversationId = input.readOptionalString(); | |||
| this.llmModel = input.readOptionalString(); | |||
| this.llmQuestion = input.readString(); | |||
| this.llmQuestion = input.readOptionalString(); | |||
There was a problem hiding this comment.
Hi @austintlee this does not quite make sense to me, why you only make llmQuestion into optional while keeping llmMessage as mandatory field, if you are trying to make user to choose one of them?
dhrubo-os
reviewed
Oct 8, 2024
| @@ -359,7 +359,7 @@ public class RestMLRAGSearchProcessorIT extends MLCommonsRestTestCase { | |||
| + " \"ext\": {\n" | |||
| + " \"generative_qa_parameters\": {\n" | |||
| + " \"llm_model\": \"%s\",\n" | |||
| + " \"llm_question\": \"%s\",\n" | |||
| // + " \"llm_question\": \"%s\",\n" | |||
There was a problem hiding this comment.
why not removing this line?
dhrubo-os
reviewed
Oct 8, 2024
| @@ -378,7 +378,7 @@ public class RestMLRAGSearchProcessorIT extends MLCommonsRestTestCase { | |||
| + " \"ext\": {\n" | |||
| + " \"generative_qa_parameters\": {\n" | |||
| + " \"llm_model\": \"%s\",\n" | |||
| + " \"llm_question\": \"%s\",\n" | |||
| // + " \"llm_question\": \"%s\",\n" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…067)
Description
Remove the check on llmQuestion being present in RAG request parameters.
Related Issues
#3067
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.