fix running tasks when circuit breaker is open #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
rbhavna
previously approved these changes
Nov 8, 2022
Zhangxunmt
previously approved these changes
Nov 8, 2022
|
CI failed https://github.com/opensearch-project/ml-commons/actions/runs/3415922046/jobs/5685553293 common issue reported |
Signed-off-by: Yaliang Wu <[email protected]>
Zhangxunmt
approved these changes
Nov 8, 2022
rbhavna
approved these changes
Nov 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
* fix running tasks when circuit breaker is open Signed-off-by: Yaliang Wu <[email protected]> * fix log error message Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 34bb2ab)
ylwu-amzn
added a commit
that referenced
this pull request
Nov 8, 2022
* fix running tasks when circuit breaker is open Signed-off-by: Yaliang Wu <[email protected]> * fix log error message Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 34bb2ab) Co-authored-by: Yaliang Wu <[email protected]>
b4sjoo
pushed a commit
to b4sjoo/ml-commons
that referenced
this pull request
Dec 2, 2022
* fix running tasks when circuit breaker is open Signed-off-by: Yaliang Wu <[email protected]> * fix log error message Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
added a commit
that referenced
this pull request
Dec 2, 2022
* fix running tasks when circuit breaker is open Signed-off-by: Yaliang Wu <[email protected]> * fix log error message Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Sicheng Song <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu [email protected]
Description
When disk circuit breaker is open, the upload model task will never completed/failed.
The original design of
String errorMsg = checkAndAddRunningTask(mlTask, maxUploadTasksPerNode);will never throw exceptions, will throw exception by checkingerrorMsg. Now circuit breaker will throw limit exceed exception insidecheckAndAddRunningTask, so we should move this method inside the try block.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.