Test PR #1092
Closed
Test PR #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pagination in Hybrid query Signed-off-by: Varun Jain <[email protected]> * Remove unwanted code Signed-off-by: Varun Jain <[email protected]> * Adding hybrid query context dto Signed-off-by: Varun Jain <[email protected]> * Adding javadoc in hybridquerycontext and addressing few comments from review Signed-off-by: Varun Jain <[email protected]> * rename hybrid query extraction method Signed-off-by: Varun Jain <[email protected]> * Refactoring to optimize extractHybridQuery method calls Signed-off-by: Varun Jain <[email protected]> * Changes in tests to adapt with builder pattern in querybuilder Signed-off-by: Varun Jain <[email protected]> * Add mapper service mock in tests Signed-off-by: Varun Jain <[email protected]> * Fix error message of index.max_result_window setting Signed-off-by: Varun Jain <[email protected]> * Fix error message of index.max_result_window setting Signed-off-by: Varun Jain <[email protected]> * Fixing validation condition for lower bound Signed-off-by: Varun Jain <[email protected]> * fix tests Signed-off-by: Varun Jain <[email protected]> * Removing version check from doEquals and doHashCode method Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
zhichao-aws,
yuye-aws and
minalsha
as code owners
Signed-off-by: Varun Jain <[email protected]>
|
DO not merge this PR now |
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1092 +/- ##
============================================
+ Coverage 80.07% 80.35% +0.28%
- Complexity 1143 1156 +13
============================================
Files 87 87
Lines 3960 4022 +62
Branches 668 681 +13
============================================
+ Hits 3171 3232 +61
+ Misses 538 535 -3
- Partials 251 255 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
|
Do not merge this PR |
vibrantvarun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR