Cleanup integ tests by removing redundant model uploads #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
force-pushed
the
cleanup_redandant_model_uploads_from_integ_tests
branch
from
04bb257
to
0a65829
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
cleanup_redandant_model_uploads_from_integ_tests
branch
from
0a65829
to
d6fc36f
Compare
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun and
zhichao-aws
as code owners
navneet1v
approved these changes
Apr 8, 2024
|
LGTM, thanks @martin-gaievski |
vibrantvarun
approved these changes
Apr 8, 2024
vibrantvarun
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 09dde7b)
martin-gaievski
added a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 09dde7b) Signed-off-by: Martin Gaievski <[email protected]>
vibrantvarun
pushed a commit
that referenced
this pull request
Apr 9, 2024
(cherry picked from commit 09dde7b) Signed-off-by: Martin Gaievski <[email protected]> Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning integ tests by removing redundant model uploads. Model upload/delete consumes lot of resources including memory for keeping local model.
That is a problem for jdk21 (default for distribution infra) as default GC may be slow with memory cleanup and tests will fail in environment with limited heap amount.
In this PR I've removed model upload from 12 out of 64 tests. Logic of these test remains unchanged, those models were not necessary as queries are text based (bm25) queries.
Issues Resolved
#667
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.