-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add html sanitization enhancement for email message #694
Open
gaobinlong
wants to merge
5
commits into
opensearch-project:main
Choose a base branch
from
gaobinlong:email_html_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws and
zhongnansu
as code owners
June 26, 2023 09:24
Codecov Report
@@ Coverage Diff @@
## main #694 +/- ##
============================================
+ Coverage 61.84% 62.66% +0.82%
- Complexity 114 144 +30
============================================
Files 73 73
Lines 2495 2601 +106
Branches 266 283 +17
============================================
+ Hits 1543 1630 +87
- Misses 775 789 +14
- Partials 177 182 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main change of this PR is to add html sanitization enhancement for sending html format email message, there are three main settings for this enhancement:
opensearch.notifications.core.email.enable_html_sanitization
, defaults to trueopensearch.notifications.core.email.html_sanitization_allow_list
, defaults to ["blocks_group", "formatting_group", "images_group", "links_group", "styles_group", "tables_group"]opensearch.notifications.core.email.html_sanitization_deny_list
, defaults to []when
enable_html_sanitization
is set to true and sending a email with html format, the content of the email will be sanitized by the html sanitizer according tohtml_sanitization_allow_list
andhtml_sanitization_deny_list
, notice thathtml_sanitization_deny_list
only takes effect whenhtml_sanitization_allow_list
is not empty.Issues Resolved
#586
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.