Fix refresh issue #802
Open
Fix refresh issue #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Bhagat <[email protected]>
Signed-off-by: Nishant Bhagat <[email protected]>
Signed-off-by: Nishant Bhagat <[email protected]>
nishantb1
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws and
zhongnansu
as code owners
|
@bobbane11 would you mind run |
zhichao-aws
reviewed
Oct 19, 2023
There was a problem hiding this comment.
We should also set refresh policy for delete action
There was a problem hiding this comment.
The Thread.sleep not only invoked in ChimeNotificationConfigCrudIT, I believe most integ tests about CRUD notification config having this proplem. Could you please find them and remove all these invocations?
Signed-off-by: Nishant Bhagat <[email protected]>
|
Please make sure the changes can pass the build at your local environment by running |
Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change of setting the refresh policy to IMMEDIATE ensures that the index is refreshed right away after a create, update, or delete operation on the notification configs. This makes the changes visible in real-time without waiting for the next scheduled refresh. It's beneficial in scenarios where immediate visibility of changes is crucial, such as in real-time applications or testing environments. By making this change, the need for Thread.sleep invocations in integration tests is eliminated, making the tests potentially faster and more reliable.
Issues Resolved
This PR will resolve the issue regarding the delay in reflecting changes when creating, updating, or deleting notification configurations due to the index not being immediately refreshed. By ensuring an immediate refresh, it enhances real-time visibility of changes, improves user interaction with the notifications API, and optimizes integration testing by removing the need for Thread.sleep invocations to wait for the index to refresh.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.