update easyMock to mock in chime test

[rohan19a]

Description

Updated a chime webhook test from easyMock to Mockk

Issues Resolved

#237

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[Hailong-am]

@rohan19a ktlint check has failed. can you run ./gradlew ktlintFormat to fix it?

[yuye-aws]

Some tests get failed. Please take a look at why.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62b7b4f) 66.85% compared to head (ec6a557) 66.85%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #815   +/-   ##
=========================================
  Coverage     66.85%   66.85%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1738     1738           
  Branches        165      165           
=========================================
  Hits           1162     1162           
  Misses          453      453           
  Partials        123      123           

Flag	Coverage Δ
opensearch-notifications	66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hailong-am]

LGTM

[zhichao-aws]

Can we replace the EasyMock with mockk in this test case also? Then we can remove the dependency for EasyMock in ChimeDestinationTests

[rohan19a]

Can we replace the EasyMock with mockk in this test case also? Then we can remove the dependency for EasyMock in ChimeDestinationTests

Missed that somehow, I'll edit that and recommit

[zhichao-aws]

lgtm

[Hailong-am]

Looks good to me, we have serval files still using easyMock, we can have follow up PR to remove them all, after that we can remove the dependency of easyMock

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-815-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d1c03a2411c057bc73543562cc166cb0944c8d
# Push it to GitHub
git push --set-upstream origin backport/backport-815-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-815-to-2.x.

[yuye-aws]

Shall we manually backport this PR to 2.x branch?

[Hailong-am]

@rohan19a would you mind to do manual backport according to #815 (comment)

[zhichao-aws]

In main branch we use mockk to create a CloseableHttpResponse instance, while in 2.x we still used EasyMock, and the code inconsistence causes the backport fail. We need to manual backport and replace all EasyMock usage in the backport PR.