Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding max http response string length as a setting, and capping http… #861

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Feb 16, 2024

Adding max http response string length as a setting, and capping http response string based on that setting

Description

Adding a cap to the length of HTTP response strings.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… response string based on that setting

Signed-off-by: Dennis Toepker <[email protected]>
@toepkerd
Copy link
Contributor Author

Note on failing CIs, with the changes stashed away locally, BWC was failing in the same places for the same reason.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a integration test for this setting to make sure only limited response will be returned?

@Hailong-am
Copy link
Collaborator

Note on failing CIs, with the changes stashed away locally, BWC was failing in the same places for the same reason.

You can skip the bwc test for now, it could pass when bwc version upgrade to 2.13

@sbcd90 sbcd90 merged commit 8c662a6 into opensearch-project:main Feb 22, 2024
23 of 26 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2024
… response string based on that setting (#861)

Signed-off-by: Dennis Toepker <[email protected]>
(cherry picked from commit 8c662a6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.9
# Create a new branch
git switch --create backport/backport-861-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c662a675e78a9f9f32d4c7ffaa67a89ade806f6
# Push it to GitHub
git push --set-upstream origin backport/backport-861-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-861-to-2.9.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.7
# Create a new branch
git switch --create backport/backport-861-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c662a675e78a9f9f32d4c7ffaa67a89ade806f6
# Push it to GitHub
git push --set-upstream origin backport/backport-861-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-861-to-2.7.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.11
# Create a new branch
git switch --create backport/backport-861-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c662a675e78a9f9f32d4c7ffaa67a89ade806f6
# Push it to GitHub
git push --set-upstream origin backport/backport-861-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-861-to-2.11.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.12
# Create a new branch
git switch --create backport/backport-861-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c662a675e78a9f9f32d4c7ffaa67a89ade806f6
# Push it to GitHub
git push --set-upstream origin backport/backport-861-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-861-to-2.12.

toepkerd added a commit to toepkerd/notifications that referenced this pull request Feb 23, 2024
… response string based on that setting (opensearch-project#861)

Signed-off-by: Dennis Toepker <[email protected]>
(cherry picked from commit 8c662a6)
toepkerd added a commit to toepkerd/notifications that referenced this pull request Feb 23, 2024
… response string based on that setting (opensearch-project#861)

Signed-off-by: Dennis Toepker <[email protected]>
(cherry picked from commit 8c662a6)
toepkerd added a commit to toepkerd/notifications that referenced this pull request Mar 14, 2024
… response string based on that setting (opensearch-project#861)

Signed-off-by: Dennis Toepker <[email protected]>
(cherry picked from commit 8c662a6)
toepkerd added a commit to toepkerd/notifications that referenced this pull request Mar 14, 2024
… response string based on that setting (opensearch-project#861)

Signed-off-by: Dennis Toepker <[email protected]>
@praveensameneni praveensameneni added the v2.13.0 Issues targeting release v2.13.0 label Mar 27, 2024
@toepkerd toepkerd mentioned this pull request Apr 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants