Fix: tests. (#388)

Signed-off-by: dblock <[email protected]>
opensearch-project · Jul 9, 2024 · 68237e6 · 68237e6
1 parent f00ed98
commit 68237e6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/tools/src/tester/ResultLogger.ts b/tools/src/tester/ResultLogger.ts
@@ -90,10 +90,20 @@ export class ConsoleResultLogger implements ResultLogger {
 
   #log_evaluation (evaluation: Evaluation, title: string, prefix: number = 0): void {
     const result = ansi.padding(this.#result(evaluation.result), 0, prefix)
+
     var message = evaluation.message
-    if (message !== undefined && message?.length > 128 && !this._verbose) message = message.split(',')[0] + ', ...'
-    if (message !== undefined) message = ansi.gray(`${message}`)
-    console.log(`${result} ${title} ${message}`)
+
+    if (message !== undefined && message?.length > 128 && !this._verbose) {
+      const message_part = message.split(',')[0]
+      message = message_part === message ? message : message_part + ', ...'
+    }
+
+    if (message !== undefined) {
+      message = ansi.gray(`(${message})`)
+      console.log(`${result} ${title} ${message}`)
+    } else {
+      console.log(`${result} ${title}`)
+    }
   }
 
   #result (r: Result): string {

diff --git a/tools/tests/tester/ResultLogger.test.ts b/tools/tests/tester/ResultLogger.test.ts
@@ -47,8 +47,8 @@ describe('ConsoleResultLogger', () => {
       expect(log.mock.calls).toEqual([
         [],
         [`${ansi.green('PASSED ')} ${ansi.cyan(ansi.b('path'))} ${ansi.gray('(message)')}`],
-        [`   ${ansi.green('PASSED ')} CHAPTERS `],
-        [`      ${ansi.green('PASSED ')} ${ansi.i('title')} `],
+        [`   ${ansi.green('PASSED ')} CHAPTERS`],
+        [`      ${ansi.green('PASSED ')} ${ansi.i('title')}`],
         []
       ])
     })

diff --git a/tools/tests/tester/test.test.ts b/tools/tests/tester/test.test.ts
@@ -41,7 +41,7 @@ test('displays story filename', () => {
 
 test('invalid story', () => {
   expect(spec(['--tests', 'tools/tests/tester/fixtures/invalid_story.yaml']).stdout).toContain(
-    `${ansi.gray("(Invalid Story: data/epilogues/0 must NOT have unevaluated properties, data/chapters/0 must have required property 'method', data/chapters/1/method must be equal to one of the allowed values)")}`
+    `${ansi.gray("(Invalid Story: data/epilogues/0 must NOT have unevaluated properties, ...)")}`
   )
 })