Add strict_allow_templates option for the dynamic mapping parameter

[gaobinlong]

Description

Add strict_allow_templates option for the dynamic mapping parameter, and remove the unsupported option runtime.

Issues Resolved

#407

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Changes Analysis

Commit SHA: 15a9826
Comparing To SHA: 34ff292

API Changes

Summary

└─┬Components
  └─┬_common.mapping:DynamicMapping
    ├──[➕] enum (33845:11)
    └──[➖] enum (33844:11)❌ 

Document Element	Total Changes	Breaking Changes
components	2	1

• ❌ BREAKING Changes: 1 out of 2
• Removals: 1
• Additions: 1
• Breaking Removals: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10061341381/artifacts/1730976728

API Coverage

	Before	After	Δ
Covered (%)	490 (47.99 %)	490 (47.99 %)	0 (0 %)
Uncovered (%)	531 (52.01 %)	531 (52.01 %)	0 (0 %)
Unknown	24	24	0

[gaobinlong]

The code PR of strict_allow_templates will be released in 2.16.0, so do we need to do some version check in this repo?

[dblock]

Please add a test into tests. You should be able to write one for the runtime change (it's a bug!), but for the new parameter you'll need to run against a newer version of OpenSearch locally.

[dblock]

Quote strict_allow_templates.

[dblock]

The code PR of strict_allow_templates will be released in 2.16.0, so do we need to do some version check in this repo?

Yes, this is #398, I have #409 ready, but still have to write a way to only run some tests against x.y.z version.

#410 will do what you want, specify version: '>= 2.16'.

[gaobinlong]

The failed test seems related to the env, the test case works well locally.

[dblock]

The failed test seems related to the env, the test case works well locally.

I think 2.16 daily isn't starting, I'll look.

[dblock]

Update CI to a newer 2.16 build that has your feature and it should all go 🟢 ?

https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29

[gaobinlong]

Update CI to a newer 2.16 build that has your feature and it should all go 🟢 ?

https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29

I think so.

[dblock]

Update CI to a newer 2.16 build that has your feature and it should all go 🟢 ?
https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29

I think so.

I mean you can do it in this PR and we can merge.

[github-actions]

Spec Test Coverage Analysis

Total	Tested
514	114 (22.18 %)

[gaobinlong]

@dblock I've updated the image version, now all checks have passed yet.

[dblock]

Great job.

[dblock]

If you want to do more, maybe move the template tests into a subfolder, so tests/indices/mapping/dynamic.yaml and add some more tests for other mapping options?

[gaobinlong]

If you want to do more, maybe move the template tests into a subfolder, so tests/indices/mapping/dynamic.yaml and add some more tests for other mapping options?

Sure, I'll do that later.