Fix: correctly combine test coverage. #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Changes AnalysisCommit SHA: 0a64621 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10624591524/artifacts/1872572320 API Coverage
|
Spec Test Coverage Analysis
|
dblock
force-pushed
the
fix-test-coverage
branch
2 times, most recently
from
db84378
to
bca035d
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
fix-test-coverage
branch
from
bca035d
to
0a64621
Compare
Xtansia
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test coverage was being combined naively and incorrectly.
I had sneaked in a minimal implementation in #513 where a bunch of tests would run in parallel, then the
jqcode that combined results would just pick the max number of tests run, which would account for the default test suite, but not for the other test suites.This is now replaced with producing a JSON that contains an actually unique set of all operations and a unique set of evaluated operations, then merge all these results, then sum up the numbers and calculate the overall percentage.
The bad news is that we were including dups in the counts, so we're not at 66% but 43.29%.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.