Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build cron for 2.5.0 to every hour #2926

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Nov 19, 2022

Signed-off-by: bowenlan-amzn [email protected]

Description

Update the cron schedule of build workflow for 2.5.0 to every hour

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn bowenlan-amzn requested a review from a team as a code owner November 19, 2022 01:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #2926 (c54aeb1) into main (4a3914a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2926   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         165      165           
  Lines        4518     4518           
=======================================
  Hits         4202     4202           
  Misses        316      316           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon
Copy link
Member

Hi @gaiksaya @prudhvigodithi I have discussed with @bowenlan-amzn offline that they want to start building 2.5.0 right now in a more frequent fashion.

Please add you thoughts on whether this is fine for now.

Thanks.

@prudhvigodithi
Copy link
Collaborator

Hey @peterzhuamazon and @bowenlan-amzn LGTM.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with increasing the frequency for the builds on 2.5.0 but just notice we only have core and CU plugin right now. Prob would need to add those plugins that are being actively developed to the manifest as well.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 19, 2022

I'm good with increasing the frequency for the builds on 2.5.0 but just notice we only have core and CU plugin right now. Prob would need to add those plugins that are being actively developed to the manifest as well.

Yeah, right now @bowenlan-amzn is waiting for the new CU maven to work on their plugins.
I would suggest Bowen add this line as well for a more frequent Core+CU deployment that does not impact the artifacts.

            H/60 * * * %INPUT_MANIFEST=2.5.0/opensearch-2.5.0.yml;TARGET_JOB_NAME=distribution-build-opensearch;BUILD_PLATFORM=linux;COMPONENT_NAME=OpenSearch common-utils;UPDATE_LATEST_URL=false

This probably need to make changes here so maven can be constantly updated without interrupting actual artifacts creation.
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/check-for-build.jenkinsfile#L89-L93

Thanks.

@gaiksaya
Copy link
Member

I would keep keep default to true and work on #2749

Posting some suggestions for anyone to pick up:
Currently, the snapshots are published only after the build is successful https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L152-L171
I believe if we want to unblock dependency on entire build, the publishing to snapshot should be a part of this stage https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L178-L218

@peterzhuamazon
Copy link
Member

I would keep keep default to true and work on #2749

Posting some suggestions for anyone to pick up: Currently, the snapshots are published only after the build is successful https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L152-L171 I believe if we want to unblock dependency on entire build, the publishing to snapshot should be a part of this stage https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L178-L218

That is also fine I just want to unblock @bowenlan-amzn right now just in case other failures block core/CU maven updates.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 565735b into opensearch-project:main Nov 19, 2022
@bowenlan-amzn bowenlan-amzn deleted the updatecron branch November 19, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants