Add async search in 2.5 manifest #3072
Conversation
manifests/2.5.0/opensearch-2.5.0.yml
Outdated
| @@ -163,3 +163,12 @@ components: | |||
| - windows | |||
| checks: | |||
| - gradle:properties:version | |||
| - name: asynchronous-search | |||
| repository: https://github.com/opensearch-project/asynchronous-search.git | |||
| ref: 2.5 | |||
There was a problem hiding this comment.
Should we add tags or branch in ref ? otherwise approving it
There was a problem hiding this comment.
Branch as tags are cut after the release. @Arpit-Bandejiya please make 2.5 a string by enclosing it in quotes. Thanks!
There was a problem hiding this comment.
Done @gaiksaya, please check.
There was a problem hiding this comment.
Looks like there is a merge conflict. Can you rebase and fix it?
Thanks!
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3072 +/- ##
==========================================
+ Coverage 92.87% 93.17% +0.30%
==========================================
Files 167 167
Lines 4602 4602
==========================================
+ Hits 4274 4288 +14
+ Misses 328 314 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi @Arpit-Bandejiya Can you rebase? The CI was fixed in recent PR. |
|
I rebased for @Arpit-Bandejiya let us see if it pass. |
|
CI are passing. I'm merging this now. |
Signed-off-by: Arpit Bandejiya [email protected]
Description
Add async search to 2.5 manifest
Issues Resolved
Part of #217
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.