Run manifest ci check only when PR is labelled #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
dblock,
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
commented
Mar 25, 2024
|
|
||
| on: | ||
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
There was a syntax error since long time hence this workflow was failing silently. :/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 192 192
Lines 6297 6297
=======================================
Hits 5804 5804
Misses 493 493 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the ci check should be optional after merge of #4523
With this change whenever a maintainer adds
manifest-ci-checklabel, only then manifest-ci-check workflow will run.This workflow is super useful when to run checks in between release candidate creations when commits are updated manually.
Will be useful also when #4561 will be implemented
Issues Resolved
#4433
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.