Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore release notes folder for link checker workflow #4614

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 8, 2024

Description

Link checker workflow has been consistently failing https://github.com/opensearch-project/opensearch-build/actions/workflows/link-checker.yml due toToo many requests
One of the culprit are the consolidated release notes which contains external links to many GH PRs and issues

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to caught 2 link errors with this check in release notes.

I am not sure if we really want to leave broken link in the release notes tho.

Thanks.

@gaiksaya
Copy link
Member Author

gaiksaya commented Apr 8, 2024

I was able to caught 2 link errors with this check in release notes.

I am not sure if we really want to leave broken link in the release notes tho.

Thanks.

We can revisit this again but as of now it is blocking the development in terms of PR merge. We can either run the check in local using lychee or use label to run for a specific file in the future.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the same issue here. #4615

I'm ok we disable it for release notes for now. Could you maybe create an issue so that we could keep track of this in the future?

@gaiksaya
Copy link
Member Author

gaiksaya commented Apr 8, 2024

Release notes do always have a failing link especially the prod website links that only go live after release is done. Will create an issue to either run based on label or create another workflow to only run against that specific release notes.md file rather than entire folder.

@gaiksaya gaiksaya merged commit 80e9dd3 into opensearch-project:main Apr 8, 2024
10 of 11 checks passed
@gaiksaya gaiksaya deleted the ignore-rn branch April 8, 2024 21:31
@gaiksaya
Copy link
Member Author

gaiksaya commented Apr 8, 2024

Release notes do always have a failing link especially the prod website links that only go live after release is done. Will create an issue to either run based on label or create another workflow to only run against that specific release notes.md file rather than entire folder.

#4616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants