Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typed-ast as it is deprecated #5058

Merged

Conversation

peterzhuamazon
Copy link
Member

Description

Remove typed-ast as it is deprecated

Issues Resolved

Closes #5054

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Member

Let's not merge until 2.17.1 is out please?

@peterzhuamazon
Copy link
Member Author

Let's not merge until 2.17.1 is out please?

Yes will wait.

@peterzhuamazon peterzhuamazon marked this pull request as draft September 26, 2024 20:40
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon marked this pull request as ready for review October 3, 2024 23:11
@peterzhuamazon
Copy link
Member Author

We can merge it now as 2.17.1 is released.
@gaiksaya

Thanks.

@peterzhuamazon peterzhuamazon merged commit 7c3045e into opensearch-project:main Oct 3, 2024
9 of 10 checks passed
@peterzhuamazon peterzhuamazon deleted the type-ast-update branch October 3, 2024 23:13
@peterzhuamazon
Copy link
Member Author

The mend failure is unrelated here.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: typed-ast dependency has been archived for Python 3.8+
2 participants