Skip to content

Commit

Permalink
Update alerting dashboard tests
Browse files Browse the repository at this point in the history 
Signed-off-by: Joanne Wang <[email protected]>
  • Loading branch information
@jowg-amazon
jowg-amazon committed Sep 19, 2024
1 parent 17cb4c4 commit 6b73c80
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 19 deletions.
8 changes: 4 additions & 4 deletions cypress/integration/plugins/alerting-dashboards-plugin/bucket_level_monitor_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ describe('Bucket-Level Monitors', () => {
// Add a trigger
addTriggerToVisualEditorMonitor(SAMPLE_TRIGGER, 0, SAMPLE_ACTION, true);

// Click update button to save monitor changes
cy.get('button').contains('Update').last().click({ force: true });
// Click save button to save monitor changes
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we can see only one row in the trigger list by checking <caption> element
cy.contains('This table contains 1 row');
Expand Down Expand Up @@ -367,8 +367,8 @@ describe('Bucket-Level Monitors', () => {
timeout: ALERTING_PLUGIN_TIMEOUT,
});

// Click the update button
cy.get('button').contains('Update').last().click({ force: true });
// Click the save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we're on the Monitor Details page by searching for the History element
cy.contains('History', { timeout: ALERTING_PLUGIN_TIMEOUT });
Expand Down
4 changes: 2 additions & 2 deletions cypress/integration/plugins/alerting-dashboards-plugin/cluster_metrics_monitor_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ describe('ClusterMetricsMonitor', () => {
'ctx.results[0].number_of_pending_tasks >= 0'
);

// Click update button to save monitor changes
cy.get('button').contains('Update').last().click({ force: true });
// Click save button to save monitor changes
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we can see only one row in the trigger list by checking <caption> element
cy.contains('This table contains 1 row');
Expand Down
3 changes: 2 additions & 1 deletion cypress/integration/plugins/alerting-dashboards-plugin/composite_level_monitor_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ describe('CompositeLevelMonitor', () => {

it('by visual editor', () => {
// Verify edit page
cy.contains('Edit').click({ force: true });
cy.contains('Edit monitor', { timeout: ALERTING_PLUGIN_TIMEOUT });
cy.get('input[name="name"]').type('_edited');

Expand Down Expand Up @@ -198,7 +199,7 @@ describe('CompositeLevelMonitor', () => {
'updateMonitorRequest',
'PUT'
);
cy.get('button').contains('Update').click({ force: true });
cy.get('button').contains('Save').click({ force: true });

// Wait for monitor to be created
cy.wait('@updateMonitorRequest').then(() => {
Expand Down
12 changes: 6 additions & 6 deletions cypress/integration/plugins/alerting-dashboards-plugin/document_level_monitor_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,8 @@ describe('DocumentLevelMonitor', () => {

// TODO: Test with Notifications plugin

// Click the update button
cy.get('button').contains('Update').last().click({ force: true });
// Click the save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we can see only one row in the trigger list by checking <caption> element
cy.contains('This table contains 2 rows');
Expand Down Expand Up @@ -512,8 +512,8 @@ describe('DocumentLevelMonitor', () => {

// TODO: Test with Notifications plugin

// Click the create button
cy.get('button').contains('Update').last().click({ force: true });
// Click the save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we can see only one row in the trigger list by checking <caption> element
cy.contains('This table contains 1 row');
Expand Down Expand Up @@ -569,8 +569,8 @@ describe('DocumentLevelMonitor', () => {
timeout: ALERTING_PLUGIN_TIMEOUT,
});

// Click the update button
cy.get('button').contains('Update').last().click({ force: true });
// Click the save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we're on the Monitor Details page by searching for the History element
cy.contains('History', { timeout: ALERTING_PLUGIN_TIMEOUT });
Expand Down
12 changes: 6 additions & 6 deletions cypress/integration/plugins/alerting-dashboards-plugin/query_level_monitor_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ describe('Query-Level Monitors', () => {
.clear()
.type(UPDATED_MONITOR, { force: true });

// Click Update button
cy.get('button').contains('Update').last().click({ force: true });
// Click save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm the update process is done and the page loaded
cy.contains('Edit monitor');
Expand Down Expand Up @@ -234,8 +234,8 @@ describe('Query-Level Monitors', () => {
timeout: ALERTING_PLUGIN_TIMEOUT,
});

// Click the update button
cy.get('button').contains('Update').last().click({ force: true });
// Click the save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we're on the Monitor Details page by searching for the History element
cy.contains('History', { timeout: ALERTING_PLUGIN_TIMEOUT });
Expand Down Expand Up @@ -368,8 +368,8 @@ describe('Query-Level Monitors', () => {
);
}

// Click Update button
cy.get('button').contains('Update').last().click({ force: true });
// Click save button
cy.get('button').contains('Save').last().click({ force: true });

// Confirm we can see the correct number of rows in the trigger list by checking <caption> element
cy.contains(`This table contains ${triggers.length} rows`, {
Expand Down

0 comments on commit 6b73c80

Please sign in to comment.