Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CYPRESS_NO_COMMAND_LOG to release signoff workflows #1009

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Jan 24, 2024

Description

The release sign off test workflow always hang during test execution.
Add CYPRESS_NO_COMMAND_LOG=1 to env variables to unhang.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam marked this pull request as ready for review January 24, 2024 08:17
@SuZhou-Joe
Copy link
Member

@wanglam do we have a link to represent the change indeed address the hang issue?

@wanglam
Copy link
Collaborator Author

wanglam commented Jan 30, 2024

@wanglam do we have a link to represent the change indeed address the hang issue?

@SuZhou-Joe I've tested in my own repo, the job can be finished after add this CYPRESS_NO_COMMAND_LOG, here is the job details.

@wanglam wanglam merged commit b5a0786 into opensearch-project:main Jan 31, 2024
39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
Hailong-am pushed a commit that referenced this pull request Jan 31, 2024
…#1026)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit b5a0786)

Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants