Fix panel test not respecting base path setting #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
Signed-off-by: Simeon Widdis <[email protected]>
This was referenced Aug 16, 2024
peterzhuamazon
approved these changes
Aug 16, 2024
Hailong-am
approved these changes
Aug 19, 2024
failed cases are not related to the change, safe to merge. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Fix panel test not respecting base path setting Signed-off-by: Simeon Widdis <[email protected]> * Apply prettier lints Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 4ff7b93)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Fix panel test not respecting base path setting Signed-off-by: Simeon Widdis <[email protected]> * Apply prettier lints Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit 4ff7b93) Co-authored-by: Simeon Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test fails if a base path is set, which doesn't show up as a problem in GH CI but does in other CI pipelines. Will need backport to 2.x for 2.17.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.