Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal Cypress tests for integrations #990

Merged
merged 13 commits into from
Jan 30, 2024

Conversation

Swiddis
Copy link
Contributor

@Swiddis Swiddis commented Jan 6, 2024

Description

Adds two Cypress tests for the Integrations plugin, taken from the dashboards-observability repository.

Issues Resolved

Resolves #989

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis changed the title Add tests for integrations Add minimal Cypress tests for integrations Jan 6, 2024
@derek-ho
Copy link
Contributor

derek-ho commented Jan 9, 2024

Blocked by #981

@ruanyl
Copy link
Member

ruanyl commented Jan 22, 2024

@Swiddis @derek-ho FYI, added backport 2.x label based on #981

@Swiddis Swiddis requested a review from ruanyl January 24, 2024 00:25
@ruanyl
Copy link
Member

ruanyl commented Jan 26, 2024

Blocked by #981

Hi @Swiddis, could you confirm if it's ok to merge this PR mow?

@Swiddis
Copy link
Contributor Author

Swiddis commented Jan 26, 2024

Yep, should be good to go

@ruanyl ruanyl merged commit 98ec499 into opensearch-project:main Jan 30, 2024
37 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2024
* Add tests for integrations

Signed-off-by: Simeon Widdis <[email protected]>

* Add check for test instance page opening

Signed-off-by: Simeon Widdis <[email protected]>

* Empty commit to re-trigger run

Signed-off-by: Simeon Widdis <[email protected]>

* Decouple integrations add and search tests

Signed-off-by: Simeon Widdis <[email protected]>

* Move instance name constant to test

Signed-off-by: Simeon Widdis <[email protected]>

* Add integrations teardown process

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit 98ec499)
Swiddis added a commit to Swiddis/opensearch-dashboards-functional-test that referenced this pull request Feb 2, 2024
* Add tests for integrations

Signed-off-by: Simeon Widdis <[email protected]>

* Add check for test instance page opening

Signed-off-by: Simeon Widdis <[email protected]>

* Empty commit to re-trigger run

Signed-off-by: Simeon Widdis <[email protected]>

* Decouple integrations add and search tests

Signed-off-by: Simeon Widdis <[email protected]>

* Move instance name constant to test

Signed-off-by: Simeon Widdis <[email protected]>

* Add integrations teardown process

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Swiddis added a commit to Swiddis/opensearch-dashboards-functional-test that referenced this pull request Feb 2, 2024
* Add tests for integrations

Signed-off-by: Simeon Widdis <[email protected]>

* Add check for test instance page opening

Signed-off-by: Simeon Widdis <[email protected]>

* Empty commit to re-trigger run

Signed-off-by: Simeon Widdis <[email protected]>

* Decouple integrations add and search tests

Signed-off-by: Simeon Widdis <[email protected]>

* Move instance name constant to test

Signed-off-by: Simeon Widdis <[email protected]>

* Add integrations teardown process

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Swiddis added a commit to Swiddis/opensearch-dashboards-functional-test that referenced this pull request Feb 2, 2024
* Add tests for integrations

Signed-off-by: Simeon Widdis <[email protected]>

* Add check for test instance page opening

Signed-off-by: Simeon Widdis <[email protected]>

* Empty commit to re-trigger run

Signed-off-by: Simeon Widdis <[email protected]>

* Decouple integrations add and search tests

Signed-off-by: Simeon Widdis <[email protected]>

* Move instance name constant to test

Signed-off-by: Simeon Widdis <[email protected]>

* Add integrations teardown process

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis mentioned this pull request Feb 2, 2024
1 task
ruanyl pushed a commit that referenced this pull request Feb 5, 2024
* Add tests for integrations



* Add check for test instance page opening



* Empty commit to re-trigger run



* Decouple integrations add and search tests



* Move instance name constant to test



* Add integrations teardown process



---------

Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] FTR tests for Integrations plugin
4 participants