httpclient builder: tls strategy customization

[jan-berge-ommedal]

Signed-off-by: Jan Berge Sommerdahl [email protected]

Description

Allows custom tls strategies to be used with ApacheHttpClient5TransportBuilder

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[wbeckler]

Hi Jan
Would you be willing to open a related issue for this with sample code of how you would want to see it used (ideally this will end up in the documentation)? Would you be up for adding a unit test? This also merits a changelog entry.

[reta]

I think providing the way to customize the TlsStrategy would be beneficial (right now you could do that by providing own connectionManager instance, which is verbose). However we should do that iin a way to keep API concise, relying on XxxCallback hooks, for example RequestConfigCallback, HttpClientConfigCallback.

    public interface ClientTlsStrategyConfigCallback {
        ClientTlsStrategyBuilder customizeClientTlsStrategyClientTlsStrategyBuilder clientTlsStrategyBuilder);
    }

[bbarani]

@wbeckler @reta @jan-berge-ommedal Anyone looking in to this PR?

[reta]

@wbeckler @reta @jan-berge-ommedal Anyone looking in to this PR?

AFAIK, nope

[dblock]

Sorry about the delay. Happy to look at the PR, needs tests, CHANGELOG and documentation, please? @jan-berge-ommedal

[Catch All Triage - 1, 2, 3, 4]