feat(chart): add cluster.general.monitoring.labels field to values.yaml #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joluc
requested review from
idanl21,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
charts/opensearch-cluster/Chart.yaml
Outdated
| type: application | ||
|
|
||
| ## The opensearch-cluster Helm Chart version | ||
| version: 3.0.0 |
There was a problem hiding this comment.
Hey @joluc apologies for the wait, can you please revert to 3.0.0 ?
What I was thinking is along with v2.8.0 #1011 we can do a helm chart release as well. So we can create the version once all changes are merged.
Anyhow without v2.8.0 operator release please correct me if i'm wrong labels waont be applied correctly.
rootxrishabh
approved these changes
Jun 26, 2025
Signed-off-by: Jonathan Schwarze <[email protected]>
joluc
force-pushed
the
fix/add-labels-for-servicemonitor-chart
branch
from
f98c468 to
5743b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces missing
cluster.general.monitoring.labelsfield in the Helm chart’s values.yaml and README documentation. The operator already supports this field. This change simply adds it in the chart so users can configure custom labels on the generated ServiceMonitor.Issues Resolved
N/A
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.