Decrease security config updater poll interval to 20s #1069
Conversation
Signed-off-by: Max Lepikhin <[email protected]>
maxlepikhin
requested review from
idanl21,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
LGTM - tested and it indeed a necessary fix |
| until curl -k --silent https://%s:%v; | ||
| do | ||
| echo 'Waiting to connect to the cluster'; sleep 120; | ||
| echo 'Waiting to connect to the cluster'; sleep 20; |
There was a problem hiding this comment.
This was added as part of https://github.com/opensearch-project/opensearch-k8s-operator/pull/198/files#diff-3f3f25087560ff69bb8867115997c9c8a5764ce6eebc95577072ad615051db3bR750, initially when I tested with EKS using EBS the security config pod failed because the cluster took time to start. This was when OpenSearch 2.0.0 was released.
Can we have any better way here, like using some cluster health API to poll if the cluster is fully ready connected with all nodes and then run the security config (or leave it as it is?) ?
@maxlepikhin @rursprung @rootxrishabh @synhershko
There was a problem hiding this comment.
i'm not using this operator, but: if your cluster has the security plugin installed then you could poll the health endpoint on /_plugins/_security/health? this does not need authentication and will return HTTP 200 if it's alive
There was a problem hiding this comment.
Agreed this is not ideal, but the 120 seconds wait doesn't make sense. @prudhvigodithi Let's get this merged and can you open an issue to discuss the right way to perform readiness checks for all possible scenarios?
Signed-off-by: Max Lepikhin <[email protected]>
maxlepikhin
force-pushed
the
feat-963
branch
from
6e70fd3 to
7e2ae0f
Compare
Description
Reduce poll interval from 120s to 20s.
Issues Resolved
Slow cluster start-up time.
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.